Encode tracker API token in HTTP requests#422
Merged
josecelano merged 2 commits intotorrust:developfrom Dec 26, 2023
Merged
Conversation
When the tracker API token contains specials characters, the token must be URL-encoded. For example: Wrong URL: http://tracker.torrust-demo.com:1212/v1/stats?token=123g7#@agJtWFSgkdA5R$K22yeo$k6IhNq%T2$r Rigth URL with encoded token: http://tracker.torrust-demo.com:1212/v1/stats?token=123g7%23%40agJtWFSgkdA5R%24K22yeo%24k6IhNq%25T2%24r
Member
Author
|
ACK 860de14 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #422 +/- ##
===========================================
- Coverage 42.99% 42.89% -0.10%
===========================================
Files 80 80
Lines 4922 4933 +11
===========================================
Hits 2116 2116
- Misses 2806 2817 +11 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the API token contains special characters like:
123g7#@agJtWFSgkdA5R$K22yeo$k6IhNq%T2$rThe value must be URL-encoded like this:
http://tracker.torrust-demo.com:1212/v1/stats?token=123g7%23%40agJtWFSgkdA5R%24K22yeo%24k6IhNq%25T2%24r
Instead of using the token directly:
http://tracker.torrust-demo.com:1212/v1/stats?token=123g7#@agJtWFSgkdA5R$K22yeo$k6IhNq%T2$r
This PR also fixes the issue #391