Use normal variables instead of secrets for user and repo on DockerHub#381
Merged
josecelano merged 1 commit intotorrust:developfrom Nov 13, 2023
Merged
Conversation
From: `torrust/index-backend:develop` To: `torrust/index:develop`
Member
Author
|
In order to rename the docker image we only need to change the GitHub env variables and trigger the But I have made some changes anyway:
I've created new env variables for the DockerHub user and repo instead of using secrets. I think we do not need secrets for that and It can help to find errors in the pipeline. |
da2ce7
approved these changes
Nov 13, 2023
Contributor
da2ce7
left a comment
da2ce7
left a comment
There was a problem hiding this comment.
Changed not related to rename, but good refactor anyhow.
josecelano
changed the title
josecelano
changed the title
user and repo on DockerHub
Member
Author
Updated. |
Member
Author
|
ACK b93564c |
Member
Author
|
I've removed the unused secrets:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From:
torrust/index-backend:developTo:
torrust/index:develop