Merged
Conversation
Closed
Member
Author
josecelano
added a commit
that referenced
this pull request
Nov 14, 2023
d92443d fix: [#342] E2E test execution with MySQL (Jose Celano) 31351fa fix: [#342] disable clippy warning (Jose Celano) f8aa238 fix: [#342] broken E2E tests after renaming Category::category_id field (Jose Celano) e78607d fix: [#342] SQLite data file path inside the container for E2E tests (Jose Celano) 1cce823 fix: [#342] index container not running for E2E tests (Jose Celano) 03943ef fix: [#342] fix en vars to run E2E tests (Jose Celano) Pull request description: The E2E test suite execution was not reestablished correctly [here](#378). Some env vars were renamed (like `TORRUST_INDEX_E2E_SHARED`) so we were not running E2E tests (although they seemed to pass, we were only executing the ones that do not require a shared env). This PR only reestablishes the E2E tests. There are a lot of pending refactors that will be done in new PRs like [renaming env vars](#361). Top commit has no ACKs. Tree-SHA512: fc8f9f89dab83b8b2cb263befc614c9c8ebec884a060e4e5c6a958827d537b4c1198e0c8cdb4b709902a9869366088dc91ac33cca15a1fdf357a215a8328589e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reestablish E2E Tests.