Refactor: the function services::torrent::Index::add_torrent#305
Merged
josecelano merged 11 commits intotorrust:developfrom Sep 20, 2023
josecelano:issue-276-refactor-add-torrent-fn
Merged
Refactor: the function services::torrent::Index::add_torrent#305josecelano merged 11 commits intotorrust:developfrom josecelano:issue-276-refactor-add-torrent-fn
services::torrent::Index::add_torrent#305josecelano merged 11 commits intotorrust:developfrom
josecelano:issue-276-refactor-add-torrent-fn
Conversation
josecelano
changed the title
services::torrent::Index::add_torrent
Codecov Report
@@ Coverage Diff @@
## develop #305 +/- ##
===========================================
+ Coverage 43.65% 44.01% +0.36%
===========================================
Files 77 77
Lines 4387 4387
===========================================
+ Hits 1915 1931 +16
+ Misses 2472 2456 -16 see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
And other minor changes.
when the original info-hash of the upload torrent cannot be calculated. The API should not return empty responses, so "panic" should not be use for common problems that we should notify to the user.
When you upload a torrent the transaction wraps all the persisted data. Before this change, if tags can't be stored in the database the rest of the indexed data is stored anyway.
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
Member
Author
|
ACK 275231a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.