Do not allow empty or duplicate tag names#293
Merged
josecelano merged 2 commits intotorrust:developfrom Sep 14, 2023
josecelano:issue-289-do-not-allow-empty-and-duplicate-tags
Merged
Do not allow empty or duplicate tag names#293josecelano merged 2 commits intotorrust:developfrom josecelano:issue-289-do-not-allow-empty-and-duplicate-tags
josecelano merged 2 commits intotorrust:developfrom
josecelano:issue-289-do-not-allow-empty-and-duplicate-tags
Conversation
It was allowed to use an empty strings like "" or " " for a tag name.
From now on, it's not allowed.
If there are some empty names in the database, they are not renamed.
A migration to rename empty names was not added because there can be more than one tag, for example:
- ""
- " "
- " "
- Etcetera
We could have generated names like "no tag 1", "no tag 2", but it's not likely that admins have created empty tags.
Duplicate tag names were allowed. This introduce unique constrains.
If there were duyplicate tags they are updated appeding the id as a suffix.
For example, having two tags:
```json
[
{
tag_id: 1,
name: "fractal"
},
{
tag_id: 2,
name: "fractal"
}
]
```
They would be renamed to:
```json
[
{
tag_id: 1,
name: "fractal_1"
},
{
tag_id: 2,
name: "fractal_2"
}
]
```
From now on, duplicate tags are not allowed.
Member
Author
|
ACK 7fedf15 |
Codecov Report
@@ Coverage Diff @@
## develop #293 +/- ##
===========================================
+ Coverage 43.63% 43.81% +0.18%
===========================================
Files 77 77
Lines 4325 4346 +21
===========================================
+ Hits 1887 1904 +17
- Misses 2438 2442 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not allow empty tag names
It was allowed to use empty strings like "" or " " for a tag name.
After merging this PR, it will not be allowed anymore.
If there are some empty names in the database, they are not renamed.
A migration to rename empty names was not added because there can be more than one tag, for example:
We could have generated names like "no tag 1", "no tag 2", but it's not likely that admins have created empty tags.
Do not allow duplicate tag names
It was allowed to use empty strings like "" or " " for a tag name. And It was also allowed to have duplicate tags.
After merging this PR, it will not be allowed anymore.
If there are duplicate tag names, the duplication is removed by appending the tag id as a suffix to the tag name.