Skip to content

Fix docker compose configuration with the new tracker container image#270

Merged
josecelano merged 1 commit intotorrust:developfrom
josecelano:update-tracker-service-in-docker-compose
Sep 11, 2023
Merged

Fix docker compose configuration with the new tracker container image#270
josecelano merged 1 commit intotorrust:developfrom
josecelano:update-tracker-service-in-docker-compose

Conversation

@josecelano
Copy link
Copy Markdown
Member

@josecelano josecelano commented Sep 7, 2023

The Torrust Tracker container image has changed.

We have to upgrade the configuration to use the latest version.

Integration tests fail for pull requests because the tracker container cannot start.

The significant changes introduced were:

  • Rename some env vars: TORRUST_TRACKER_API_TOKEN->TORRUST_TRACKER_API_ADMIN_TOKEN
  • Database folder was moved to a new location

@josecelano josecelano mentioned this pull request Sep 7, 2023
Merged
@josecelano josecelano marked this pull request as ready for review September 7, 2023 16:09
@josecelano josecelano requested a review from da2ce7 September 7, 2023 16:09
@josecelano
Copy link
Copy Markdown
Member Author

josecelano commented Sep 7, 2023

You can see here on example of workflow failing:

https://github.com/torrust/torrust-index-backend/actions/runs/6100451779/job/16556658907?pr=269

You can see in the docker ps output that the tracker service is not running:

Container torrust-mysql-1 is healthy
CONTAINER ID   IMAGE                       COMMAND                  CREATED          STATUS                    PORTS                                                                                  NAMES
8adcaa70a0ab   torrust-idx-back            "cargo run"              34 seconds ago   Up 32 seconds             0.0.0.0:3001->3001/tcp, :::3001->3001/tcp                                              torrust-idx-back-1
fa41beb4de15   mysql:8.0                   "docker-entrypoint.s…"   34 seconds ago   Up 33 seconds (healthy)   0.0.0.0:3306->3306/tcp, :::3306->3306/tcp, 33060/tcp                                   torrust-mysql-1
4842ffb5e42a   dockage/mailcatcher:0.8.2   "entrypoint mailcatc…"   34 seconds ago   Up 33 seconds             0.0.0.0:1025->1025/tcp, :::1025->1025/tcp, 0.0.0.0:1080->1080/tcp, :::1080->1080/tcp   torrust-mailcatcher-1

da2ce7
da2ce7 approved these changes Sep 7, 2023
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #270 (739a646) into develop (b3fe7f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #270   +/-   ##
========================================
  Coverage    44.77%   44.77%           
========================================
  Files           77       77           
  Lines         4121     4121           
========================================
  Hits          1845     1845           
  Misses        2276     2276

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

da2ce7
da2ce7 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@da2ce7 da2ce7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

This was referenced Sep 11, 2023
Closed
Merged
@josecelano
fix: docker compose with the new tracker container image
bf95d85 
The Torrust Tracker container image has changed. Upgrade the
configuration to use the latest version.
@josecelano
Copy link
Copy Markdown
Member Author

josecelano commented Sep 11, 2023

ACk bf95d85

@josecelano josecelano merged commit 158757b into torrust:develop Sep 11, 2023
@josecelano josecelano mentioned this pull request Sep 11, 2023
Merged
josecelano added a commit that referenced this pull request Sep 11, 2023
@josecelano
Merge #274: Clean sqlite bash commands
f493964 
891a744 fix: clean sqlite bash commands (Jose Celano)

Pull request description:

  I forgot some changes in the previous [PR](#270).

Top commit has no ACKs.

Tree-SHA512: 5a44e6f8979db9109650341cf510162c9a0dee786fc5baca2fa4d9f80fe8c920b4004829b4d36fc5be1b8c728c0130ec2766ba07f62e6a94eef1edb4c1badd6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@da2ce7 da2ce7 da2ce7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Torrust Solution
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josecelano @codecov-commenter @da2ce7