Skip to content

#262: Add tower-http compression middleware#263

Merged
josecelano merged 1 commit intotorrust:developfrom
alexohneander:develop
Aug 30, 2023
Merged

#262: Add tower-http compression middleware#263
josecelano merged 1 commit intotorrust:developfrom
alexohneander:develop

Conversation

@alexohneander
Copy link
Copy Markdown
Contributor

Modified:
I have added the tower-http compression to the router.
One test fails, but this did not work before my changes.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #263 (bf3f66f) into develop (79ff3cc) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
- Coverage    44.80%   44.77%   -0.04%     
===========================================
  Files           77       77              
  Lines         4111     4121      +10     
===========================================
+ Hits          1842     1845       +3     
- Misses        2269     2276       +7     
Files Changed Coverage Δ
src/web/api/v1/routes.rs 95.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@josecelano josecelano requested a review from da2ce7 August 27, 2023 09:06
@josecelano
Copy link
Copy Markdown
Member

ACK bf3f66f

@josecelano josecelano linked an issue Aug 27, 2023 that may be closed by this pull request
@josecelano
Copy link
Copy Markdown
Member

Modified: I have added the tower-http compression to the router. One test fails, but this did not work before my changes.

Hi @alexohneander thank you! I do not see any failing test.

@alexohneander
Copy link
Copy Markdown
Contributor Author

@josecelano
I have locally the following Failure:

failures:
    e2e::web::api::v1::contexts::torrent::contract::for_authenticated_users::it_should_not_allow_uploading_a_torrent_with_a_non_existing_category

@josecelano
Copy link
Copy Markdown
Member

@josecelano I have locally the following Failure:

failures:
    e2e::web::api::v1::contexts::torrent::contract::for_authenticated_users::it_should_not_allow_uploading_a_torrent_with_a_non_existing_category

Hi @alexohneander, I'm going to merge the PR because ti seems to work, but I would like to know why it's not working for you. You can run the test with:

cargo test it_should_not_allow_uploading_a_torrent_with_a_non_existing_category -- --nocapture

And it should show more info.

@josecelano
Copy link
Copy Markdown
Member

And @alexohneander, we use Conventional Commits. The commit message could be something like:

feat: [#263] add compression to HTTP responses

@josecelano josecelano merged commit b3fe7f9 into torrust:develop Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add middleware to compress responses

3 participants