Run E2E tests also using MySQL#252
Merged
josecelano merged 3 commits intotorrust:developfrom Aug 9, 2023
josecelano:issue-223-run-e2e-test-with-mysql
Merged
Run E2E tests also using MySQL#252josecelano merged 3 commits intotorrust:developfrom josecelano:issue-223-run-e2e-test-with-mysql
josecelano merged 3 commits intotorrust:developfrom
josecelano:issue-223-run-e2e-test-with-mysql
Conversation
Member
Author
|
With this first version, we can run the E2E tests with MySQL. I have to refactor the code to remove duplication; it's just the first iteration. On the other hand, one test is failing with MySQL: It does not allow to add duplicate categories, but the MySQL version returns a 500 instead of a 400. |
E2E tests are only executed with SQLite.
…y in MySQL Using MySQL the endpoint to inser categories returns a different HTTP status code. It should return a 400 and It was returning a 500. The reason is we parse the error message and for MySQL the error message is not the same as SQLite: MySQL: ``` Error: Duplicate entry 'category name 118802' for key 'torrust_categories.name' ``` It has been changed but we should now rely on concrete error messages. Besides we should not relay on the database contrains, mahybe we should check in the handler that the category does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E tests are only executed with SQLite.