Fix: missing tables in Database::delete_all_database_rows function#220
Merged
josecelano merged 2 commits intotorrust:developfrom Jun 26, 2023
josecelano:issue-194-delete-database-tests
Merged
Fix: missing tables in Database::delete_all_database_rows function#220josecelano merged 2 commits intotorrust:developfrom josecelano:issue-194-delete-database-tests
josecelano merged 2 commits intotorrust:developfrom
josecelano:issue-194-delete-database-tests
Conversation
Because: - They are hard to maintain because of the table's dependencies. - They are duplicated in E2E tests. And it's easier to set the state you want to test with E2E tests. TODO: runt the E2E test using MySQL to ensure queries are OK. Currently, E2E tests are only executed with SQLite.
When you upgrade from v1.0.0 to v2.0.0 you can run an upgrader which will truncate all the tables in the target database. There were some missing tables in the list. Probably, there wre tables added after creting the upgrader command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the function
delete_all_database_rowsto delete all tables.Besides, remove database tests because:
TODO: runt the E2E test using MySQL to ensure queries are OK. Currently, E2E tests are only executed with SQLite.