Refactor configuration#138
Merged
josecelano merged 2 commits intotorrust:developfrom May 4, 2023
josecelano:issue-130-refactor-configuration
Merged
Refactor configuration#138josecelano merged 2 commits intotorrust:developfrom josecelano:issue-130-refactor-configuration
josecelano merged 2 commits intotorrust:developfrom
josecelano:issue-130-refactor-configuration
Conversation
The test `it_should_allow_admins_to_update_all_the_settings` overwrites the config file `config.toml`. It uses the same values but: 1. That does not assert that the file was actually updated. 2. It can lead to conflicts with other tests since all of them use the same shared env. For isolated environments, it should not be a problem becuase we inject the configuration into the app directly wuthout getting it from the environment via confif file or env var.
Member
Author
Clean code for E2E test env configuration initialization. And the configuration is loaded from the same config file used to start the docker container: `config-idx-back.local.toml`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
it_should_allow_admins_to_update_all_the_settingsoverwrites the config fileconfig.toml. It uses the same values but:It should be fine for isolated environments because we inject the configuration into the app directly (not getting it from the environment via config file or env var).
This PR fixes it by running only the tests for isolated envs.
The PR includes other refactorings for configuration.