feat: [#91] added image proxy with cache#134
Conversation
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
Hey @WarmBeer, it looks good to me.
Cargo.toml
Outdated
| bytes = "1.4.0" | ||
| text-to-png = "0.2.0" | ||
| indexmap = "1.9.3" |
There was a problem hiding this comment.
Hi @WarmBeer, I changed all dependencies to use only the minor versions so that you can upgrade patches.
bytes = "1.4"
text-to-png = "0.2"
indexmap = "1.9"
mickvandijke
force-pushed
the
rebase-91-add-endpoint-for-image-proxying
branch
2 times, most recently
from
39a6218 to
dc279db
Compare
mickvandijke
force-pushed
the
rebase-91-add-endpoint-for-image-proxying
branch
from
dc279db to
916d869
Compare
|
Hi @josecelano , I still have 1 failing test after rebasing. Is there something else I need to do? |
@WarmBeer, that's the test I knew would fail because you added a new section to the configuration. Let's merge the PR, and I will fix it since I will start working on this issue, which is related to configuration. But just for let you know, you only need to add the new section in here. |
I'm fixing it in a new branch with a new commit. I will replace this PR with the new one in a few minutes. |
2 participants
Rebased and processed @josecelano 's feedback: #100