Refactor: extract logic from E2E tests to reuse it for integration tests#128
Merged
josecelano merged 1 commit intotorrust:developfrom Apr 28, 2023
josecelano:refactor-extract-common-for-integration-tests
Merged
Refactor: extract logic from E2E tests to reuse it for integration tests#128josecelano merged 1 commit intotorrust:developfrom josecelano:refactor-extract-common-for-integration-tests
josecelano merged 1 commit intotorrust:developfrom
josecelano:refactor-extract-common-for-integration-tests
Conversation
josecelano
changed the title
…ests E2E tests run an independent application process with docker, and then they are executed against that public service. It's only one instance. Integrations tests will use an independent process for each test, running the API on a different port. The instance SUT is launched by the tests. We need to refactor the application bootstrapping to be able lo launch an app instance from tests. This refactor allows us to reuse the code from E2E tests in future integration tests.
Member
Author
|
Hi @da2ce7 @WarmBeer, this is ready for review. My plan is:
After those steps, we will be able to start writing integration tests on demand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E tests run an independent application process with docker, and then the test are executed against that single service.
Integration tests will use an independent process for each test, running the API on a different port. The tests launch their instances. We need to refactor the application bootstrapping to be able to launch an app instance programmatically, as we did for the tracker.
This refactoring allows us to reuse the code from E2E tests in future integration tests.