fix: clippy errors

josecelano · josecelano · commit a8aad7a482fb · 2023-08-21T14:29:26.000+01:00
diff --git a/src/config.rs b/src/config.rs
@@ -318,7 +318,7 @@ impl Configuration {
             warn!("No config file found. Creating default config file ...");
 
             let config = Configuration::default();
-            let _ = config.save_to_file(config_path).await;
+            let () = config.save_to_file(config_path).await;
 
             return Err(ConfigError::Message(format!(
                 "No config file found. Created default config file in {config_path}. Edit the file and start the application."
diff --git a/src/databases/mysql.rs b/src/databases/mysql.rs
@@ -510,7 +510,7 @@ impl Database for Mysql {
             let announce_urls = announce_urls.iter().flatten().collect::<Vec<&String>>();
 
             for tracker_url in &announce_urls {
-                let _ = query("INSERT INTO torrust_torrent_announce_urls (torrent_id, tracker_url) VALUES (?, ?)")
+                let () = query("INSERT INTO torrust_torrent_announce_urls (torrent_id, tracker_url) VALUES (?, ?)")
                     .bind(torrent_id)
                     .bind(tracker_url)
                     .execute(&mut tx)
diff --git a/src/databases/sqlite.rs b/src/databases/sqlite.rs
@@ -498,7 +498,7 @@ impl Database for Sqlite {
             let announce_urls = announce_urls.iter().flatten().collect::<Vec<&String>>();
 
             for tracker_url in &announce_urls {
-                let _ = query("INSERT INTO torrust_torrent_announce_urls (torrent_id, tracker_url) VALUES (?, ?)")
+                let () = query("INSERT INTO torrust_torrent_announce_urls (torrent_id, tracker_url) VALUES (?, ?)")
                     .bind(torrent_id)
                     .bind(tracker_url)
                     .execute(&mut tx)
diff --git a/src/services/category.rs b/src/services/category.rs
@@ -65,7 +65,7 @@ impl Service {
         }
 
         match self.category_repository.delete(category_name).await {
-            Ok(_) => Ok(()),
+            Ok(()) => Ok(()),
             Err(e) => match e {
                 DatabaseError::CategoryNotFound => Err(ServiceError::CategoryNotFound),
                 _ => Err(ServiceError::DatabaseError),
diff --git a/src/services/tag.rs b/src/services/tag.rs
@@ -39,7 +39,7 @@ impl Service {
         }
 
         match self.tag_repository.add(tag_name).await {
-            Ok(_) => Ok(()),
+            Ok(()) => Ok(()),
             Err(e) => match e {
                 DatabaseError::TagAlreadyExists => Err(ServiceError::TagAlreadyExists),
                 _ => Err(ServiceError::DatabaseError),
@@ -65,7 +65,7 @@ impl Service {
         }
 
         match self.tag_repository.delete(tag_id).await {
-            Ok(_) => Ok(()),
+            Ok(()) => Ok(()),
             Err(e) => match e {
                 DatabaseError::TagNotFound => Err(ServiceError::TagNotFound),
                 _ => Err(ServiceError::DatabaseError),
diff --git a/src/web/api/v1/contexts/category/handlers.rs b/src/web/api/v1/contexts/category/handlers.rs
@@ -81,7 +81,7 @@ pub async fn delete_handler(
     };
 
     match app_data.category_service.delete_category(&category_form.name, &user_id).await {
-        Ok(_) => deleted_category(&category_form.name).into_response(),
+        Ok(()) => deleted_category(&category_form.name).into_response(),
         Err(error) => error.into_response(),
     }
 }
diff --git a/src/web/api/v1/contexts/tag/handlers.rs b/src/web/api/v1/contexts/tag/handlers.rs
@@ -52,7 +52,7 @@ pub async fn add_handler(
     };
 
     match app_data.tag_service.add_tag(&add_tag_form.name, &user_id).await {
-        Ok(_) => added_tag(&add_tag_form.name).into_response(),
+        Ok(()) => added_tag(&add_tag_form.name).into_response(),
         Err(error) => error.into_response(),
     }
 }
@@ -77,7 +77,7 @@ pub async fn delete_handler(
     };
 
     match app_data.tag_service.delete_tag(&delete_tag_form.tag_id, &user_id).await {
-        Ok(_) => deleted_tag(delete_tag_form.tag_id).into_response(),
+        Ok(()) => deleted_tag(delete_tag_form.tag_id).into_response(),
         Err(error) => error.into_response(),
     }
 }
diff --git a/src/web/api/v1/contexts/user/handlers.rs b/src/web/api/v1/contexts/user/handlers.rs
@@ -145,7 +145,7 @@ pub async fn ban_handler(
     };
 
     match app_data.ban_service.ban_user(&to_be_banned_username.0, &user_id).await {
-        Ok(_) => Json(OkResponseData {
+        Ok(()) => Json(OkResponseData {
             data: format!("Banned user: {}", to_be_banned_username.0),
         })
         .into_response(),

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ impl Service {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`match self.category_repository.delete(category_name).await {`
`68`		`- Ok(_) => Ok(()),`
	`68`	`+ Ok(()) => Ok(()),`
`69`	`69`	`Err(e) => match e {`
`70`	`70`	`DatabaseError::CategoryNotFound => Err(ServiceError::CategoryNotFound),`
`71`	`71`	`_ => Err(ServiceError::DatabaseError),`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ pub async fn delete_handler(`
`81`	`81`	`};`
`82`	`82`
`83`	`83`	`match app_data.category_service.delete_category(&category_form.name, &user_id).await {`
`84`		`- Ok(_) => deleted_category(&category_form.name).into_response(),`
	`84`	`+ Ok(()) => deleted_category(&category_form.name).into_response(),`
`85`	`85`	`Err(error) => error.into_response(),`
`86`	`86`	`}`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ pub async fn add_handler(`
`52`	`52`	`};`
`53`	`53`
`54`	`54`	`match app_data.tag_service.add_tag(&add_tag_form.name, &user_id).await {`
`55`		`- Ok(_) => added_tag(&add_tag_form.name).into_response(),`
	`55`	`+ Ok(()) => added_tag(&add_tag_form.name).into_response(),`
`56`	`56`	`Err(error) => error.into_response(),`
`57`	`57`	`}`
`58`	`58`	`}`
`@@ -77,7 +77,7 @@ pub async fn delete_handler(`
`77`	`77`	`};`
`78`	`78`
`79`	`79`	`match app_data.tag_service.delete_tag(&delete_tag_form.tag_id, &user_id).await {`
`80`		`- Ok(_) => deleted_tag(delete_tag_form.tag_id).into_response(),`
	`80`	`+ Ok(()) => deleted_tag(delete_tag_form.tag_id).into_response(),`
`81`	`81`	`Err(error) => error.into_response(),`
`82`	`82`	`}`
`83`	`83`	`}`