refactor: remove unneeded code

josecelano · josecelano · commit 548558904930 · 2023-06-05T17:36:04.000+01:00
diff --git a/src/console/commands/import_tracker_statistics.rs b/src/console/commands/import_tracker_statistics.rs
@@ -35,17 +35,14 @@ use crate::tracker::statistics_importer::StatisticsImporter;
 
 const NUMBER_OF_ARGUMENTS: usize = 0;
 
-#[derive(Debug)]
-pub struct Arguments {}
-
 #[derive(Debug, Display, PartialEq, Error)]
 #[allow(dead_code)]
 pub enum ImportError {
     #[display(fmt = "internal server error")]
     WrongNumberOfArgumentsError,
 }
 
-fn parse_args() -> Result<Arguments, ImportError> {
+fn parse_args() -> Result<(), ImportError> {
     let args: Vec<String> = env::args().skip(1).collect();
 
     if args.len() != NUMBER_OF_ARGUMENTS {
@@ -59,7 +56,7 @@ fn parse_args() -> Result<Arguments, ImportError> {
         return Err(ImportError::WrongNumberOfArgumentsError);
     }
 
-    Ok(Arguments {})
+    Ok(())
 }
 
 fn print_usage() {
@@ -74,15 +71,16 @@ fn print_usage() {
 }
 
 pub async fn run_importer() {
-    import(&parse_args().expect("unable to parse command arguments")).await;
+    parse_args().expect("unable to parse command arguments");
+    import().await;
 }
 
 /// Import Command Arguments
 ///
 /// # Panics
 ///
 /// Panics if `Configuration::load_from_file` has any error.
-pub async fn import(_args: &Arguments) {
+pub async fn import() {
     println!("Importing statistics from linked tracker ...");
 
     let configuration = init_configuration().await;
@@ -110,5 +108,5 @@ pub async fn import(_args: &Arguments) {
     tracker_statistics_importer
         .import_all_torrents_statistics()
         .await
-        .expect("variable `tracker_service` is unable to `update_torrents`");
+        .expect("should import all torrents statistics");
 }
diff --git a/src/tracker/statistics_importer.rs b/src/tracker/statistics_importer.rs
@@ -50,10 +50,11 @@ impl StatisticsImporter {
             // ```
 
             if let Some(err) = ret.err() {
-                error!(
+                let message = format!(
                     "Error updating torrent tracker stats for torrent with id {}: {:?}",
                     torrent.torrent_id, err
                 );
+                error!("{}", message);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -50,10 +50,11 @@ impl StatisticsImporter {`
`50`	`50`	// ```
`51`	`51`
`52`	`52`	`if let Some(err) = ret.err() {`
`53`		`- error!(`
	`53`	`+ let message = format!(`
`54`	`54`	`"Error updating torrent tracker stats for torrent with id {}: {:?}",`
`55`	`55`	`torrent.torrent_id, err`
`56`	`56`	`);`
	`57`	`+ error!("{}", message);`
`57`	`58`	`}`
`58`	`59`	`}`
`59`	`60`