refactor: [#581] remove unused code

josecelano · josecelano · commit 1a2830922170 · 2024-05-17T17:05:28.000+01:00
diff --git a/src/config/mod.rs b/src/config/mod.rs
@@ -226,16 +226,12 @@ impl Tsl {
 pub struct Configuration {
     /// The state of the configuration.
     pub settings: RwLock<TorrustIndex>,
-    /// The path to the configuration file. This is `None` if the configuration
-    /// was loaded from the environment.
-    pub config_path: Option<String>,
 }
 
 impl Default for Configuration {
     fn default() -> Configuration {
         Configuration {
             settings: RwLock::new(TorrustIndex::default()),
-            config_path: None,
         }
     }
 }
@@ -268,7 +264,6 @@ impl Configuration {
 
         Ok(Configuration {
             settings: RwLock::new(index_config),
-            config_path: None,
         })
     }
 
diff --git a/tests/environments/app_starter.rs b/tests/environments/app_starter.rs
@@ -10,7 +10,6 @@ use torrust_index::{app, config};
 /// It launches the app and provides a way to stop it.
 pub struct AppStarter {
     configuration: config::TorrustIndex,
-    config_path: Option<String>,
     /// The application binary state (started or not):
     ///  - `None`: if the app is not started,
     ///  - `RunningState`: if the app was started.
@@ -19,10 +18,9 @@ pub struct AppStarter {
 
 impl AppStarter {
     #[must_use]
-    pub fn with_custom_configuration(configuration: config::TorrustIndex, config_path: Option<String>) -> Self {
+    pub fn with_custom_configuration(configuration: config::TorrustIndex) -> Self {
         Self {
             configuration,
-            config_path,
             running_state: None,
         }
     }
@@ -35,7 +33,6 @@ impl AppStarter {
     pub async fn start(&mut self, api_version: Version) {
         let configuration = Configuration {
             settings: RwLock::new(self.configuration.clone()),
-            config_path: self.config_path.clone(),
         };
 
         // Open a channel to communicate back with this function
diff --git a/tests/environments/isolated.rs b/tests/environments/isolated.rs
@@ -33,12 +33,8 @@ impl TestEnv {
         let temp_dir = TempDir::new().expect("failed to create a temporary directory");
 
         let configuration = ephemeral(&temp_dir);
-        // Even if we load the configuration from the environment variable, we
-        // still need to provide a path to save the configuration when the
-        // configuration is updated via the `POST /settings` endpoints.
-        let config_path = format!("{}/config.toml", temp_dir.path().to_string_lossy());
 
-        let app_starter = AppStarter::with_custom_configuration(configuration, Some(config_path));
+        let app_starter = AppStarter::with_custom_configuration(configuration);
 
         Self { app_starter, temp_dir }
     }

Original file line number	Diff line number	Diff line change
`@@ -226,16 +226,12 @@ impl Tsl {`
`226`	`226`	`pub struct Configuration {`
`227`	`227`	`/// The state of the configuration.`
`228`	`228`	`pub settings: RwLock<TorrustIndex>,`
`229`		- /// The path to the configuration file. This is `None` if the configuration
`230`		`- /// was loaded from the environment.`
`231`		`- pub config_path: Option<String>,`
`232`	`229`	`}`
`233`	`230`
`234`	`231`	`impl Default for Configuration {`
`235`	`232`	`fn default() -> Configuration {`
`236`	`233`	`Configuration {`
`237`	`234`	`settings: RwLock::new(TorrustIndex::default()),`
`238`		`- config_path: None,`
`239`	`235`	`}`
`240`	`236`	`}`
`241`	`237`	`}`
`@@ -268,7 +264,6 @@ impl Configuration {`
`268`	`264`
`269`	`265`	`Ok(Configuration {`
`270`	`266`	`settings: RwLock::new(index_config),`
`271`		`- config_path: None,`
`272`	`267`	`})`
`273`	`268`	`}`
`274`	`269`