Add support for embedding models#21
Merged
tonybaloney merged 10 commits intotonybaloney:mainfrom May 26, 2025
Merged
Conversation
cmbrose
force-pushed
the
cmbrose/embeddings-support
branch
2 times, most recently
from
94d8a27 to
b208f68
Compare
tonybaloney
reviewed
May 26, 2025
tonybaloney
reviewed
May 26, 2025
llm_github_models.py
Outdated
| ) | ||
|
|
||
| kwargs = { | ||
| "input": texts, |
Owner
There was a problem hiding this comment.
input in EmbeddingModel accepts a iterable of str or bytes, whereas client.embed takes str or Embedding Token. For now, I think bytes will probably fail. We should add a test for that too
tonybaloney
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Exposes the already-defined embedding models for use with
llm embed. Additionally exposes smaller dimension versions oftext-embedding-3-large(256, 1024) andtext-embedding-3-small(512).I took the approach from the openai embedding models from
llmitself.