Skip to content

Commit 089e92c

Browse files
committed
Remove defensive UPDATE ... FROM guard
The early-return at the top of the Update arm rejects any UPDATE with a FROM clause, even though update_to_plan already accepts from: Option<TableWithJoins> and lowers it correctly via plan_from_tables. This matches the SQL-layer change in apache#21530 (kosiew), which additionally adds assignment-qualifier preservation and a fail- closed physical-planner guard. TimeFusion intercepts DML at the logical layer (DmlQueryPlanner), so only the SQL guard removal is required. Tracking: apache#19950
1 parent eae7bf4 commit 089e92c

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

‎datafusion/sql/src/statement.rs‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1084,11 +1084,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
10841084
}
10851085
let update_from = from_clauses.and_then(|mut f| f.pop());
10861086

1087-
// UPDATE ... FROM is currently not working
1088-
// TODO fix https://github.com/apache/datafusion/issues/19950
1089-
if update_from.is_some() {
1090-
return not_impl_err!("UPDATE ... FROM is not supported");
1091-
}
10921087

10931088
if returning.is_some() {
10941089
plan_err!("Update-returning clause not yet supported")?;

0 commit comments

Comments
 (0)