Repository navigation
build: use rustls instead of OpenSSL for HTTPS - #1161
Merged
Merged
Conversation
tontinton
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isahc 2 already defaults to rustls, we were opting out of it with
native-tls-static. Switching back drops OpenSSL from the build, soOPENSSL_NO_VENDORandperlgo away, and certificates get checked by the OS throughrustls-platform-verifier, so a CA in the macOS keychain should just work (#1016).ca_fileandSSL_CERT_FILEbehave the same as before. Related to #1100, but keeps isahc and smol.Clean builds of
maki, M3 Pro, average of 2 runs:main, vendored OpenSSLmain,OPENSSL_NO_VENDORTested on macOS and in an Alpine musl build. I haven't tried Windows, the Nix flake, or a keychain-only CA yet.
I used Claude Code for the benchmarks and TLS checks and reviewed the result myself.