fix(desktop): bundle libsecret in Linux artifacts (#374)#634
Merged
Conversation
nstus
force-pushed
the
fix/appimage-libsecret
branch
from
48a9893 to
bb7b232
Compare
The desktop app uses keytar for OS keychain access, which on Linux loads libsecret-1.so.0 at runtime. On systems where libsecret is not preinstalled, the app crashes immediately with: Error: libsecret-1.so.0: cannot open shared object file Fixes #374 with two changes: 1. MakerDeb and MakerRpm now declare libsecret as a runtime dependency (libsecret-1-0 / libsecret), so the package manager will install it or refuse to install without it. 2. The AppImage is self-contained, so a postMake hook in forge.config.ts runs linuxdeploy to bundle libsecret + transitive deps into the AppImage after make completes. CD installs linuxdeploy on the Linux x64 runner. The hook is a no-op if linuxdeploy isn't on PATH, so local builds without it still succeed. The hook is gated to platform=linux, arch=x64. arm64 AppImage bundling needs a separate approach (arm64 runner or qemu) and will be a follow-up once arm64 AppImage builds are enabled. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
nstus
force-pushed
the
fix/appimage-libsecret
branch
from
bb7b232 to
f7fd70c
Compare
Successful WEB deployment 🚀🚀🚀Well done! |
Successful iPad build 🚀🚀🚀Well done! |
nvasilchuk
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app uses keytar for OS keychain access, which on Linux loads libsecret-1.so.0 at runtime. On systems where libsecret is not preinstalled, the app crashes immediately with:
Error: libsecret-1.so.0: cannot open shared object file
Fixes #374 with two changes:
MakerDeb and MakerRpm now declare libsecret as a runtime dependency (libsecret-1-0 / libsecret), so the package manager will install it or refuse to install without it.
The AppImage is self-contained, so a postMake hook in forge.config.ts runs linuxdeploy to bundle libsecret + transitive deps into the AppImage after make completes. CD installs linuxdeploy on the Linux x64 runner. The hook is a no-op if linuxdeploy isn't on PATH, so local builds without it still succeed.
The hook is gated to platform=linux, arch=x64. arm64 AppImage bundling needs a separate approach (arm64 runner or qemu) and will be a follow-up once arm64 AppImage builds are enabled.