fix(uikit): guard against empty string conversion on currency swap#594
Merged
Merged
Conversation
nstus
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's fixed
Fixed a crash when toggling currencies with an empty input value.
Problem
When the user clicked the currency toggle button while the input field was empty (''), the application crashed with the error:
Cannot convert non-integer value to bigint.Root cause
The onToggleCurrency function was calling
inputValueToBN()directly on the secondary value without checking if it was empty. When the input was empty,inputValueToBN('')threw an error because it couldn't convert an empty string to a BigNumber/bigint.Solution
Extracted the secondary value into a variable and added a guard condition to pass new BigNumber(0) instead of trying to convert an empty string.
Demo
2026-04-20.22.27.03.mov
2026-04-20.22.29.13.mov