Extension Search bar implementation#439
Merged
tomlin7 merged 3 commits intotomlin7:mainfrom Oct 26, 2024
Merged
Conversation
tomlin7
approved these changes
Oct 26, 2024
Owner
tomlin7
left a comment
tomlin7
left a comment
There was a problem hiding this comment.
Code looks very clean! tested the feature and works well
Contributor
Author
|
Thanks ! Good to know |
Owner
|
@Kabiirk happy hacktoberfest! ❤️ |
Contributor
Author
|
@tomlin7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tomlin7 ,
This closes Issue #409.
I've opted for a simple search logic that returns exact matches. Also searching for an empty string would give you the complete (initial) string as well.
Search feature can be triggered either by pressing the
SEARCHicon in the top right (beside theREFRESHicon), or by pressing<ENTER>key after typing.