Skip to content

fix: Fix PRs being displayed with issues#309

Merged
tomlin7 merged 3 commits intotomlin7:mainfrom
vyshnav-vinod:fix/github
May 14, 2024
Merged

fix: Fix PRs being displayed with issues#309
tomlin7 merged 3 commits intotomlin7:mainfrom
vyshnav-vinod:fix/github

Conversation

@vyshnav-vinod
Copy link
Copy Markdown
Contributor

Note: GitHub's REST API considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response.

In the API docs, it shows that the PRs also get included in the issues. So biscuit was also showing PRs with the issues. This PR should fix that.

Copy link
Copy Markdown
Owner

@tomlin7 tomlin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good fix, the bug went unnoticed :)

also apparently instead of making it O(2n) we can just use an extra condition below.

@tomlin7 tomlin7 merged commit ae804a2 into tomlin7:main May 14, 2024
@vyshnav-vinod vyshnav-vinod deleted the fix/github branch May 14, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants