Merged
Conversation
Fixed issue causing a new tab to be opened when selecting a file who already has a tab opened tomlin7#244
Contributor
Author
|
Hey @billyeatcookies it would be also better to maybe make a |
tomlin7
approved these changes
Mar 18, 2024
Owner
tomlin7
left a comment
tomlin7
left a comment
There was a problem hiding this comment.
@vyshnav-vinod the requirements-dev.txt idea is nice but since biscuit is not planned to be published on pypi I just didn't give it much of a thought, currently the requirements.txt serves purpose of both type of (dev + build) environments.
Changes to the code:
- since
open_editoris the main interface to opening existing files from directory tree, that can be modified, so let's leave theadd_editorfunction as it is rn.
Contributor
Author
|
The current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #244
Fixed the bug of a new tab being opened while clicking a file who already has a tab opened in the editor