Prevent a VM transport from being used with BrokerView (apache#1845)

cshannon · jgallimore · commit 2988d5fff64a · 2026-04-17T11:03:05.000+01:00
This prevents a VM transport URI from being used when adding a connector or a network connector through the Broker MBean (cherry picked from commit ef53b5b)
diff --git a/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java b/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java
@@ -579,10 +579,8 @@ private static void validateAllowedUri(URI uri, int depth) throws URISyntaxExcep
         }
     }
 
-    // We don't allow VM transport scheme to be used
-    private static void validateAllowedScheme(String scheme) {
-        if (scheme.equals("vm")) {
-            throw new IllegalArgumentException("VM scheme is not allowed");
-        }
+    @Override
+    public long getTotalMaxUncommittedExceededCount() {
+        return safeGetBroker().getDestinationStatistics().getMaxUncommittedExceededCount().getCount();
     }
 }
diff --git a/activemq-unit-tests/src/test/java/org/apache/activemq/broker/jmx/MBeanTest.java b/activemq-unit-tests/src/test/java/org/apache/activemq/broker/jmx/MBeanTest.java
@@ -2072,5 +2072,4 @@ public void testAddVmConnectorBlockedBrokerView() throws Exception {
         }
 
     }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -579,10 +579,8 @@ private static void validateAllowedUri(URI uri, int depth) throws URISyntaxExcep`
`579`	`579`	`}`
`580`	`580`	`}`
`581`	`581`
`582`		`- // We don't allow VM transport scheme to be used`
`583`		`- private static void validateAllowedScheme(String scheme) {`
`584`		`- if (scheme.equals("vm")) {`
`585`		`- throw new IllegalArgumentException("VM scheme is not allowed");`
`586`		`- }`
	`582`	`+ @Override`
	`583`	`+ public long getTotalMaxUncommittedExceededCount() {`
	`584`	`+ return safeGetBroker().getDestinationStatistics().getMaxUncommittedExceededCount().getCount();`
`587`	`585`	`}`
`588`	`586`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2072,5 +2072,4 @@ public void testAddVmConnectorBlockedBrokerView() throws Exception {`
`2072`	`2072`	`}`
`2073`	`2073`
`2074`	`2074`	`}`
`2075`		`-`
`2076`	`2075`	`}`