simpler runOnce logic

tomcz · tomcz · commit d6b7c6458ab4 · 2021-05-31T12:31:32.000+10:00
diff --git a/scraper.go b/scraper.go
@@ -130,11 +130,11 @@ func (s *Scraper) Start(ctx context.Context) error {
 }
 
 func (s *Scraper) runOnce() {
+	result := "fail"
 	if s.scrape() {
-		scrapeCounter.WithLabelValues("ok").Inc()
-	} else {
-		scrapeCounter.WithLabelValues("fail").Inc()
+		result = "ok"
 	}
+	scrapeCounter.WithLabelValues(result).Inc()
 }
 
 func (s *Scraper) scrape() bool {

Original file line number	Diff line number	Diff line change
`@@ -130,11 +130,11 @@ func (s *Scraper) Start(ctx context.Context) error {`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`func (s *Scraper) runOnce() {`
	`133`	`+ result := "fail"`
`133`	`134`	`if s.scrape() {`
`134`		`- scrapeCounter.WithLabelValues("ok").Inc()`
`135`		`- } else {`
`136`		`- scrapeCounter.WithLabelValues("fail").Inc()`
	`135`	`+ result = "ok"`
`137`	`136`	`}`
	`137`	`+ scrapeCounter.WithLabelValues(result).Inc()`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`func (s *Scraper) scrape() bool {`