Skip to content

Consistently use worker_threads instead of core_threads #7186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Darksonn merged 1 commit into from
Feb 28, 2025
Merged

Consistently use worker_threads instead of core_threads #7186

Darksonn merged 1 commit into from
Feb 28, 2025

Conversation

@aaamourao
Copy link
Contributor

@aaamourao aaamourao commented Feb 27, 2025

Motivation

The builder parameter core_threads was renamed to worker_threads but it wasn't consistently renamed inside the code, what might be confusing.

Solution

Renamed core_threads local variables to worker_threads in builder.rs.

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Feb 28, 2025
Darksonn
Darksonn approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 20c1fdc into tokio-rs:master Feb 28, 2025
87 checks passed
@Darksonn Darksonn mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees

No one assigned

Labels

A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaamourao @Darksonn @maminrayej