Skip to content

Run tests under panic=abort#749

Merged
Darksonn merged 16 commits into
masterfrom
alice/panic-abort-tests
Dec 10, 2024
Merged

Run tests under panic=abort#749
Darksonn merged 16 commits into
masterfrom
alice/panic-abort-tests

Conversation

@Darksonn
Copy link
Copy Markdown
Member

@Darksonn Darksonn commented Dec 4, 2024

No description provided.

@Darksonn Darksonn requested a review from taiki-e December 10, 2024 16:18
Comment thread ci/panic-abort.sh Outdated
Comment thread tests/test_bytes.rs
}

#[test]
#[cfg_attr(not(panic = "unwind"), ignore)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg_attr(not(panic = "unwind"), ignore)]
#[cfg_attr(panic = "abort", ignore)]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be additional panic strategies in the future.

Comment thread tests/test_bytes.rs
}

#[test]
#[cfg_attr(not(panic = "unwind"), ignore)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg_attr(not(panic = "unwind"), ignore)]
#[cfg_attr(panic = "abort", ignore)]

@Darksonn Darksonn merged commit f7072c9 into master Dec 10, 2024
@Darksonn Darksonn deleted the alice/panic-abort-tests branch December 10, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants