Return more chunks from Take::chunks_vectored#476
Closed
vorner wants to merge 1 commit into
Closed
Conversation
Specialize the `Take`s implementation of the method so it can return as many chunks as possible, instead of the default 1. Implements #474.
Member
|
I'm merging #617 with several changes. I listed you on the commit as well, since it ended up being a combination of the two PRs. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specialize the
Takes implementation of the method so it can return asmany chunks as possible, instead of the default 1.
Implements #474.
(I'm not marking it „Closes“, as there's still the open question if the guarantee in the documentation should be relaxed; I think this makes sense even if it gets relaxed because it allows for more optimal use of
write_vectoredand similar).