Paragraphs and inline image#1
Merged
todvora merged 3 commits intotodvora:masterfrom Nov 6, 2015
aschempp:fix-paragraph
Merged
Conversation
Owner
|
Hi Andreas, Best regards, |
Contributor
Author
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've installed this plugin and like it a lot. However, I found out that the Markdown parser is always adding a paragraph for each line.
Problem 1
will result in this HTML:
This plugin then converts it to a figure with caption. However, a figure (block element) is not allowed within a paragraph (invalid HTML).
Problem 2
Additionally, it will break the content if the image is inline.
will result in
Converting the inline image in this case is wrong, because it would become a block element due to
<figure>(apart from problem 1).Solution
I have changed the plugin to only handle image tags that are inside empty paragraphs, and then also remove the paragraph. I hope my assumption about the markdown parser is correct, but as the plugin is for Gitbook I guess we can assume always the same parser…