Remove #![feature(naked_functions)] and compile Cortex-M on stable!
#3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arch/risc-v
Contributor
|
Looks like cortex-m0 builds are broken due to some missing imports @bradjc |
Contributor
Author
|
This is blocked on #3803 |
bradjc
added
the
blocked
This was referenced Jan 18, 2024
bradjc
force-pushed
the
remove-naked
branch
3 times, most recently
from
5f35e72 to
f7f7c22
Compare
1 task
The compiler seems to be placing the global_asm code differently, meaning a branch instruction no longer works. Load the address and branch to the register instead.
lschuermann
previously approved these changes
Feb 8, 2024
bradjc
removed
the
blocked
Member
|
Seems like one unintended(?) consequence of this PR is that our script / Makefile hackery to generate |
Only include flags which require nightly if we are compiling on nightly.
lschuermann
approved these changes
Feb 8, 2024
alevy
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is a realization of the long-desired #1654 (at least for arm). Switches
#[naked]toglobal_asm!().It seems like no one cares to stabilize naked_functions. There was momentum 1.5 years ago, but that was derailed and it seems like projects looking to use stable are just using
global_asm!().I somewhat arbitrarily decided to switch hail to use stable as an example.
Testing Strategy
Running on nrf52840dk.
TODO or Help Wanted
One odd thing came up:
Doesn't seem to work the same way on stable. With that, even when building for a board the cfg doesn't match and the function/variable is removed. It's the
target_featurepart which doesn't seem to work the same way.Documentation Updated
/docs, or no updates are required.Formatting
make prepush.