Remove #![feature(const_mut_refs)]
#3082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the const_mut_refs unstable feature and all uses of it. For the most part, this just required making every const constructor that created a `TakeCell` no longer const, as a result of `TakeCell::empty()` no longer being const. Thanks to the updated peripheral instantation approach in tock#2069 and related PRs, this was very straightforward to perform, as peripherals no longer need to be created in const context.
github-actions
bot
added
chips/nrf
29 tasks
alistair23
approved these changes
Jul 17, 2022
lschuermann
approved these changes
Jul 18, 2022
bradjc
approved these changes
Jul 18, 2022
Contributor
bradjc
left a comment
bradjc
left a comment
There was a problem hiding this comment.
Oh wow, this change really just amounts to removing const in a few places. Great. We definitely couldn't have done this before.
Contributor
|
This gets us closer to a long standing goal (#1654), marking as last call. |
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR removes the
const_mut_refsunstable feature and all uses of it. For the most part, this just required making every const constructor that created aTakeCellno longer const, as a result ofTakeCell::empty()no longer being const. Thanks to the updated peripheral instantation approach in #2069 and related PRs, this was very straightforward to perform, as peripherals no longer need to be created in const context.Testing Strategy
This pull request was tested by compiling, no functional changes are included.
TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.