Update Rust nightly version + Expose virtual-function-elimination #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/size-reduction
branch
from
0de7066 to
6bcb084
Compare
github-actions
bot
added
chips/sam4l
hudson-ayers
changed the title
hudson-ayers
reviewed
Jul 4, 2022
By enabling virtual-function-elimination we can reduce the size of the
final binaries. Here is a before and after for OpenTitan:
Before:
Binary: 139K
.text: 22818
After
Binary: 136K
.text: 21d0c
As virtual-function-elimination is still experimental let's not enable
it by default, but leave it as an option. This allows people to test it
and help contribute improvements and bug reports back to the Rust
compiler.
Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/size-reduction
branch
from
6bcb084 to
cf60608
Compare
Contributor
|
At a glance the netlify failure appears to be a real rustdoc error: https://app.netlify.com/sites/docs-tockosorg/deploys/62c376c0f1e20d0008fd820c |
bradjc
previously approved these changes
Jul 5, 2022
Signed-off-by: Alistair Francis <[email protected]>
github-actions
bot
added
the
tock-libraries
Contributor
Author
|
Fixed the build failures |
hudson-ayers
approved these changes
Jul 6, 2022
hudson-ayers
approved these changes
Jul 6, 2022
| // available. | ||
| /// Statically validate the size and offsets of the fields defined | ||
| /// within the register struct through the [`register_structs!`] | ||
| /// within the register struct through the `register_structs!()` |
Contributor
There was a problem hiding this comment.
I took a stab at keeping the rustdoc link and failed to get it to build, so I am fine with removing it
bradjc
approved these changes
Jul 7, 2022
Contributor
|
bors r+ |
Contributor
29 tasks
ppannuto
added a commit
that referenced
this pull request
Aug 19, 2022
`tock-registers` now supports stable Rust! There is a small breaking change, documented below, required to support Rust 2021 edition. Most of the remaining changes are improvements to the internal self-testing infrastructure and documentation. There are also some additions to `FieldValue` to improve ergonomics. **Breaking Changes** - #2842: tock-registers: rename TryFromValue::try_from to try_from_value - #2833: Update to Rust 2021 edition Other Changes - #3126: [trivial] tock-registers: mark two methods as `const` - #3088: tock_registers/test_fields: respect struct size padding w/ alignment - #3072: Update Rust nightly version + Expose virtual-function-elimination - libraries/tock-register-interface: Fixup register_structs documentation - #2988: Remove const_fn_trait_bound feature and update nightly (Mar 2022) - #3014: tock-registers: Implement From field enum value type for FieldValue - #3013: tock-register-interface: Provide none method for FieldValue type - #2916: tock-register-interface: improve read_as_enum documentation - #2922: tock-register-interface: replace register tests by const assertions
ppannuto
added a commit
that referenced
this pull request
Aug 19, 2022
`tock-registers` now supports stable Rust! There is a small breaking change, documented below, required to support Rust 2021 edition. Most of the remaining changes are improvements to the internal self-testing infrastructure and documentation. There are also some additions to `FieldValue` to improve ergonomics. **Breaking Changes** - #2842: tock-registers: rename TryFromValue::try_from to try_from_value - #2833: Update to Rust 2021 edition Other Changes - #3126: [trivial] tock-registers: mark two methods as `const` - #3088: tock_registers/test_fields: respect struct size padding w/ alignment - #3072: Update Rust nightly version + Expose virtual-function-elimination - libraries/tock-register-interface: Fixup register_structs documentation - #2988: Remove const_fn_trait_bound feature and update nightly (Mar 2022) - #3014: tock-registers: Implement From field enum value type for FieldValue - #3013: tock-register-interface: Provide none method for FieldValue type - #2916: tock-register-interface: improve read_as_enum documentation - #2922: tock-register-interface: replace register tests by const assertions
ppannuto
added a commit
that referenced
this pull request
Aug 19, 2022
`tock-registers` now supports stable Rust! There is a small breaking change, documented below, required to support Rust 2021 edition. Most of the remaining changes are improvements to the internal self-testing infrastructure and documentation. There are also some additions to `FieldValue` to improve ergonomics. **Breaking Changes** - #2842: tock-registers: rename TryFromValue::try_from to try_from_value - #2838: Update to Rust 2021 edition Other Changes - #3126: [trivial] tock-registers: mark two methods as `const` - #3088: tock_registers/test_fields: respect struct size padding w/ alignment - #3072: Update Rust nightly version + Expose virtual-function-elimination - libraries/tock-register-interface: Fixup register_structs documentation - #2988: Remove const_fn_trait_bound feature and update nightly (Mar 2022) - #3014: tock-registers: Implement From field enum value type for FieldValue - #3013: tock-register-interface: Provide none method for FieldValue type - #2916: tock-register-interface: improve read_as_enum documentation - #2922: tock-register-interface: replace register tests by const assertions
bors bot
added a commit
that referenced
this pull request
Aug 24, 2022
3151: tock-registers: release v0.8 r=lschuermann a=ppannuto ### Pull Request Overview Prepare a v0.8 release of tock-registers. Fixes #2982. --- `tock-registers` now supports stable Rust! There is a small breaking change, documented below, required to support Rust 2021 edition. Most of the remaining changes are improvements to the internal self-testing infrastructure and documentation. There are also some additions to `FieldValue` to improve ergonomics. **Breaking Changes** - #2842: tock-registers: rename TryFromValue::try_from to try_from_value - #2838: Update to Rust 2021 edition Other Changes - #3126: [trivial] tock-registers: mark two methods as `const` - #3088: tock_registers/test_fields: respect struct size padding w/ alignment - #3072: Update Rust nightly version + Expose virtual-function-elimination - libraries/tock-register-interface: Fixup register_structs documentation - #2988: Remove const_fn_trait_bound feature and update nightly (Mar 2022) - #3014: tock-registers: Implement From field enum value type for FieldValue - #3013: tock-register-interface: Provide none method for FieldValue type - #2916: tock-register-interface: improve read_as_enum documentation - #2922: tock-register-interface: replace register tests by const assertions ### Testing Strategy N/A ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [ ] Ran `make prepush`. Co-authored-by: Pat Pannuto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
By enabling virtual-function-elimination we can reduce the size of the
final binaries. Here is a before and after for OpenTitan:
Before:
Binary: 139K
.text: 22818
After
Binary: 136K
.text: 21d0c
As virtual-function-elimination is still experimental let's not enable
it by default, but leave it as an option. This allows people to test it
and help contribute improvements and bug reports back to the Rust
compiler.
Testing Strategy
CI
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.