remove all uses of unstable const_in_array_repeat_expressions feature #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
lschuermann
approved these changes
Nov 23, 2020
Member
lschuermann
left a comment
lschuermann
left a comment
There was a problem hiding this comment.
Reading the Rust PR it seems like this is only a proposal to acknowledge that [CONST; N] is stable, not a commitment. Nonetheless this change can't hurt and it seems much closer to stable (well, actually is) than const_in_array_repeat_expression.
bradjc
approved these changes
Nov 24, 2020
hudson-ayers
added
the
P-Upkeep
alistair23
approved these changes
Nov 30, 2020
Contributor
|
bors r+ |
1 similar comment
Contributor
|
bors r+ |
Contributor
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request removes all uses of the unstable
const_in_array_repeat_expressionsfeature. It was originally necessary in order to have ergonomic scheduler components, but a subset of the feature that is sufficient for our use was accidentally stabilized, and the Rust maintainers are moving to make that stabilization permanent (see rust-lang/rust#79270). So this is an easy way to get rid of an unstable feature.Testing Strategy
This pull request was tested by compiling and flashing several apps on an Imix.
TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.