Remove core::intrinsics::math #1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is old, and probably has no business being in the kernel. The only thing using it is a capsule for an obsolete chip.
brghena
approved these changes
Jun 19, 2020
hudson-ayers
approved these changes
Jun 19, 2020
alistair23
approved these changes
Jun 19, 2020
ppannuto
approved these changes
Jun 19, 2020
Member
ppannuto
left a comment
ppannuto
left a comment
There was a problem hiding this comment.
bors r+
See also: tock/tock-archive#1
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1654.
This math is old, and probably shouldn't be in the kernel. The only thing using it is a capsule for an obsolete chip. There was some discussion about this somewhere, and I think the conclusion was we don't really need a capsule for a sensor that is not on any boards and is an obsolete part.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.