Update Rust nightly version#1546
Conversation
rustup update nightly just doesn't print the needed version number for the new rust compiler. I'm not sure how to get it, so we require the user to type it in for us.
No longer need to manually include it in the makefile.
gendx
left a comment
gendx
left a comment
There was a problem hiding this comment.
Regarding rust-lang/rust#67887 (which sounds quite useful for debugging by the way), could you document what is the increase in code size for the various boards?
I had a quick look, and it seems that overall code and/or data size decreased on all boards with this change :) |
I think that the primary reason that we currently use |
|
|
||
| echo "Please enter the version of Rust to use." | ||
| echo "It is probably just one day later than whatever was printed out above." | ||
| read BEST_DATE |
There was a problem hiding this comment.
This is unfortunate, but really probably only run by Tock core folks, so not really a problem
|
bors r+ |
1546: Update Rust nightly version r=ppannuto a=bradjc ### Pull Request Overview It has been about 3 months, so a good time to stay current. Also motivated by rust-lang/rust#67887 which should make debugging easier. Changes - New warning about `()` not needed. - Update to update script. ### Testing Strategy travis ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Brad Campbell <[email protected]>
Build succeeded |
As discussed in rust-lang/rust#67875, there is a difference between 'private' and 'hidden' items. Documenting private is now the default for **bin** crates, but we also want documentation for all of private library crates to be generated as well. Compare: - Before #1546: https://5e23ab06b4899600087c8c17--docs-tockosorg.netlify.com/nrf52/ficr/ - After #1546: https://deploy-preview-1546--docs-tockosorg.netlify.com/nrf52/ficr/ This restores our previous documentation
1546: Update Rust nightly version r=ppannuto a=bradjc ### Pull Request Overview It has been about 3 months, so a good time to stay current. Also motivated by rust-lang/rust#67887 which should make debugging easier. Changes - New warning about `()` not needed. - Update to update script. ### Testing Strategy travis ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make formatall`. Co-authored-by: Brad Campbell <[email protected]>
4 participants
Pull Request Overview
It has been about 3 months, so a good time to stay current. Also motivated by rust-lang/rust#67887 which should make debugging easier.
Changes
()not needed.Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.