Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust nightly version #1546

Merged
merged 3 commits into from
Jan 19, 2020
Merged

Update Rust nightly version #1546

merged 3 commits into from
Jan 19, 2020

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jan 16, 2020

Pull Request Overview

It has been about 3 months, so a good time to stay current. Also motivated by rust-lang/rust#67887 which should make debugging easier.

Changes

  • New warning about () not needed.
  • Update to update script.

Testing Strategy

travis

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

bradjc added 3 commits January 16, 2020 15:27
@bradjc
update rust version
40eeda0
@bradjc
tools: update update script
b178496 
rustup update nightly just doesn't print the needed version number for
the new rust compiler. I'm not sure how to get it, so we require the
user to type it in for us.
@bradjc
make: doc: --document-private-items is default
e2fa42d 
No longer need to manually include it in the makefile.
gendx
gendx reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@gendx gendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding rust-lang/rust#67887 (which sounds quite useful for debugging by the way), could you document what is the increase in code size for the various boards?

@gendx
Copy link
Contributor

gendx commented Jan 17, 2020

Regarding rust-lang/rust#67887 (which sounds quite useful for debugging by the way), could you document what is the increase in code size for the various boards?

I had a quick look, and it seems that overall code and/or data size decreased on all boards with this change :)

@hudson-ayers
Copy link
Contributor

Regarding rust-lang/rust#67887 (which sounds quite useful for debugging by the way), could you document what is the increase in code size for the various boards?

I had a quick look, and it seems that overall code and/or data size decreased on all boards with this change :)

I think that the primary reason that we currently use .expect() rather than .unwrap() was to make it easy to trace the source of panics, so with this change I would be all for changing most .expect() calls back to .unwrap() which should reduce data size by removing storage for the strings passed to .except()

ppannuto
ppannuto approved these changes Jan 17, 2020
View reviewed changes
tools/update_rust_version.sh

echo "Please enter the version of Rust to use."
echo "It is probably just one day later than whatever was printed out above."
read BEST_DATE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate, but really probably only run by Tock core folks, so not really a problem

@ppannuto
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 19, 2020
@bors @bradjc
Merge #1546
d27d606 
1546: Update Rust nightly version r=ppannuto a=bradjc

### Pull Request Overview

It has been about 3 months, so a good time to stay current. Also motivated by rust-lang/rust#67887 which should make debugging easier.

Changes
- New warning about `()` not needed.
- Update to update script.


### Testing Strategy

travis


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make formatall`.


Co-authored-by: Brad Campbell <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 19, 2020

Build succeeded

@bors bors bot merged commit e2fa42d into master Jan 19, 2020
@bors bors bot deleted the update-rust-2020-01 branch January 19, 2020 22:31
ppannuto added a commit that referenced this pull request Jan 20, 2020
@ppannuto
doc: restore documentation for hidden items
727c5ed 
As discussed in rust-lang/rust#67875, there is a
difference between 'private' and 'hidden' items. Documenting private is
now the default for **bin** crates, but we also want documentation for
all of private library crates to be generated as well. Compare:

 - Before #1546: https://5e23ab06b4899600087c8c17--docs-tockosorg.netlify.com/nrf52/ficr/
 -  After #1546: https://deploy-preview-1546--docs-tockosorg.netlify.com/nrf52/ficr/

This restores our previous documentation
@ppannuto ppannuto mentioned this pull request Jan 20, 2020
Merged
2 tasks
@alistair23 alistair23 mentioned this pull request Jan 20, 2020
Merged
9 tasks
@bradjc bradjc mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppannuto ppannuto ppannuto approved these changes

@gendx gendx gendx approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradjc @gendx @hudson-ayers @ppannuto