Merged
Conversation
Contributor
Author
|
I'm not sure why the prettier job always fails for my PRs, I think because it's looking for the branch in the original repo (for some reason) while it exists in a fork. |
Owner
|
Nice idea, thanks for the PR! I would just go with the single |
Contributor
Author
|
Thanks for getting this merged @tobyzerner ! Unrelated, but I also just discovered that you have also already provided support for the Atomic Operations extension including support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I propose to add a convenience method to directly set a literal default value on fields, instead of using a callback. The callback is nice for scenario's like setting dynamic values based on the
Context, but in a lot of cases we just want to set a default "hardcoded" value.I've added a second method called
defaultLiteral()so the choice between using a callback or a literal value is more explicit and there is less chance of accidental errors/bugs in my opinion. And I kept the originaldefault()method so as to not introduce breaking changes. But I'm also open to other solutions if you prefer another approach.However, I will be traveling the next two weeks and won't have access to my workstation so any changes you'd like you'll either have to implement yourself or wait for a couple of weeks. I will have access to my email/github to exchange messages though.
Thanks for the consideration!