feat: allow limiting ToMany relationships#102
Closed
SychO9 wants to merge 2 commits intotobyzerner:mainfrom
Closed
feat: allow limiting ToMany relationships#102SychO9 wants to merge 2 commits intotobyzerner:mainfrom
ToMany relationships#102SychO9 wants to merge 2 commits intotobyzerner:mainfrom
Conversation
Contributor
Author
|
hmm, would be smarter to just allow constraining the query. #103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The https://github.com/staudenmeir/eloquent-eager-limit package allows limiting relationship results, Laravel 11 will officially support this: laravel/framework#49695.
This PR adds support for the feature, allowing
ToManyrelationships to be limited by simply passing->limit(6), this is especially useful when all that's needed is a subset of results, which is a great performance improvement.