Repository navigation
fix(parser): prioritize parsing parenthesized expressions as Tuple when multi-expression CSV exists - #7807
Merged
georgesittas merged 1 commit intoJun 29, 2026
Conversation
…en multi-expression CSV exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing parenthesized expressions where the first item is a subquery (e.g.
((SELECT 42), 1)), the parser's_parse_parenmethod matches theisinstance(this, (exp.Subquery, exp.Values))check first and constructs aSubqueryobject, dropping subsequent items (such as, 1).This PR fixes this by checking if the CSV contains multiple expressions (i.e.,
len(expressions) > 1or a trailing comma) first, which constructs anexp.Tupleand correctly preserves all elements.I have added a unit test verifying that
((SELECT 42), 1)parses as aTuplesuccessfully.Closes #7805