Fix(parser): allow 'cube' to be used for identifiers (#3850)

georgesittas · web-flow · commit 89976c1dbb61 · 2024-07-29T20:06:49.000+03:00
diff --git a/sqlglot/parser.py b/sqlglot/parser.py
@@ -393,6 +393,7 @@ class Parser(metaclass=_Parser):
         TokenType.COMMIT,
         TokenType.CONSTRAINT,
         TokenType.COPY,
+        TokenType.CUBE,
         TokenType.DEFAULT,
         TokenType.DELETE,
         TokenType.DESC,
@@ -3827,7 +3828,7 @@ def _parse_group(self, skip_group_by_token: bool = False) -> t.Optional[exp.Grou
         while True:
             expressions = self._parse_csv(
                 lambda: None
-                if self._match(TokenType.ROLLUP, advance=False)
+                if self._match_set((TokenType.CUBE, TokenType.ROLLUP), advance=False)
                 else self._parse_assignment()
             )
             if expressions:
diff --git a/tests/fixtures/identity.sql b/tests/fixtures/identity.sql
@@ -868,6 +868,7 @@ SELECT name
 SELECT copy
 SELECT rollup
 SELECT unnest
+SELECT cube, cube.x FROM cube
 SELECT * FROM a STRAIGHT_JOIN b
 SELECT COUNT(DISTINCT "foo bar") FROM (SELECT 1 AS "foo bar") AS t
 SELECT vector
