fix(oracle): Allow optional format in TO_DATE (#3637)

VaggelisD · web-flow · commit 4f8edba78d07 · 2024-06-12T13:51:11.000+03:00
diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -5765,7 +5765,7 @@ class StrPosition(Func):
 
 
 class StrToDate(Func):
-    arg_types = {"this": True, "format": True}
+    arg_types = {"this": True, "format": False}
 
 
 class StrToTime(Func):
diff --git a/tests/dialects/test_oracle.py b/tests/dialects/test_oracle.py
@@ -42,6 +42,7 @@ def test_oracle(self):
         self.validate_identity("SELECT * FROM table_name SAMPLE (25) s")
         self.validate_identity("SELECT COUNT(*) * 10 FROM orders SAMPLE (10) SEED (1)")
         self.validate_identity("SELECT * FROM V$SESSION")
+        self.validate_identity("SELECT TO_DATE('January 15, 1989, 11:00 A.M.')")
         self.validate_identity(
             "SELECT last_name, employee_id, manager_id, LEVEL FROM employees START WITH employee_id = 100 CONNECT BY PRIOR employee_id = manager_id ORDER SIBLINGS BY last_name"
         )

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ def test_oracle(self):`
`42`	`42`	`self.validate_identity("SELECT * FROM table_name SAMPLE (25) s")`
`43`	`43`	`self.validate_identity("SELECT COUNT() 10 FROM orders SAMPLE (10) SEED (1)")`
`44`	`44`	`self.validate_identity("SELECT * FROM V$SESSION")`
	`45`	`+ self.validate_identity("SELECT TO_DATE('January 15, 1989, 11:00 A.M.')")`
`45`	`46`	`self.validate_identity(`
`46`	`47`	`"SELECT last_name, employee_id, manager_id, LEVEL FROM employees START WITH employee_id = 100 CONNECT BY PRIOR employee_id = manager_id ORDER SIBLINGS BY last_name"`
`47`	`48`	`)`