Fix!: parse right-hand side of <value> IN (<query>) as a Subquery (#3304)

georgesittas · web-flow · commit 3c97d3437ea5 · 2024-04-11T22:50:21.000+03:00
* Fix!: parse right-hand side of &lt;value&gt; IN (&lt;query&gt;) as a Subquery

* PR feedback
diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -855,10 +855,14 @@ def isin(
         copy: bool = True,
         **opts,
     ) -> In:
+        subquery = maybe_parse(query, copy=copy, **opts) if query else None
+        if subquery and not isinstance(subquery, Subquery):
+            subquery = subquery.subquery(copy=False)
+
         return In(
             this=maybe_copy(self, copy),
             expressions=[convert(e, copy=copy) for e in expressions],
-            query=maybe_parse(query, copy=copy, **opts) if query else None,
+            query=subquery,
             unnest=(
                 Unnest(
                     expressions=[
diff --git a/sqlglot/generator.py b/sqlglot/generator.py
@@ -2706,7 +2706,7 @@ def in_sql(self, expression: exp.In) -> str:
         is_global = " GLOBAL" if expression.args.get("is_global") else ""
 
         if query:
-            in_sql = self.wrap(self.sql(query))
+            in_sql = self.sql(query)
         elif unnest:
             in_sql = self.in_unnest_op(unnest)
         elif field:
diff --git a/sqlglot/parser.py b/sqlglot/parser.py
@@ -3835,7 +3835,7 @@ def _parse_in(self, this: t.Optional[exp.Expression], alias: bool = False) -> ex
             expressions = self._parse_csv(lambda: self._parse_select_or_expression(alias=alias))
 
             if len(expressions) == 1 and isinstance(expressions[0], exp.Query):
-                this = self.expression(exp.In, this=this, query=expressions[0])
+                this = self.expression(exp.In, this=this, query=expressions[0].subquery(copy=False))
             else:
                 this = self.expression(exp.In, this=this, expressions=expressions)
 
