fix(optimizer): don't use datetrunc type for right side (#3614)

barakalon · web-flow · commit 0e1a1fb31de5 · 2024-06-07T15:16:26.000-04:00
* fix(optimizer): don't use datetrunc type for right side

* fixup
diff --git a/sqlglot/optimizer/simplify.py b/sqlglot/optimizer/simplify.py
@@ -1034,7 +1034,7 @@ def simplify_datetrunc(expression: exp.Expression, dialect: Dialect) -> exp.Expr
 
         return (
             DATETRUNC_BINARY_COMPARISONS[comparison](
-                trunc_arg, date, unit, dialect, extract_type(trunc_arg, r)
+                trunc_arg, date, unit, dialect, extract_type(r)
             )
             or expression
         )
@@ -1060,7 +1060,7 @@ def simplify_datetrunc(expression: exp.Expression, dialect: Dialect) -> exp.Expr
                 return expression
 
             ranges = merge_ranges(ranges)
-            target_type = extract_type(l, *rs)
+            target_type = extract_type(*rs)
 
             return exp.or_(
                 *[_datetrunc_eq_expression(l, drange, target_type) for drange in ranges], copy=False
diff --git a/tests/fixtures/optimizer/simplify.sql b/tests/fixtures/optimizer/simplify.sql
@@ -1047,6 +1047,9 @@ x < CAST('2021-01-02' AS DATE) AND x >= CAST('2021-01-01' AS DATE);
 TIMESTAMP_TRUNC(x, YEAR) = CAST(CAST('2021-01-01 01:02:03' AS DATE) AS DATETIME);
 x < CAST('2022-01-01 00:00:00' AS DATETIME) AND x >= CAST('2021-01-01 00:00:00' AS DATETIME);
 
+DATE_TRUNC('day', CAST(x AS DATE)) <= CAST('2021-01-01 01:02:03' AS TIMESTAMP);
+CAST(x AS DATE) < CAST('2021-01-02 01:02:03' AS TIMESTAMP);
+
 --------------------------------------
 -- EQUALITY
 --------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -1034,7 +1034,7 @@ def simplify_datetrunc(expression: exp.Expression, dialect: Dialect) -> exp.Expr`
`1034`	`1034`
`1035`	`1035`	`return (`
`1036`	`1036`	`DATETRUNC_BINARY_COMPARISONS[comparison](`
`1037`		`- trunc_arg, date, unit, dialect, extract_type(trunc_arg, r)`
	`1037`	`+ trunc_arg, date, unit, dialect, extract_type(r)`
`1038`	`1038`	`)`
`1039`	`1039`	`or expression`
`1040`	`1040`	`)`
`@@ -1060,7 +1060,7 @@ def simplify_datetrunc(expression: exp.Expression, dialect: Dialect) -> exp.Expr`
`1060`	`1060`	`return expression`
`1061`	`1061`
`1062`	`1062`	`ranges = merge_ranges(ranges)`
`1063`		`- target_type = extract_type(l, *rs)`
	`1063`	`+ target_type = extract_type(*rs)`
`1064`	`1064`
`1065`	`1065`	`return exp.or_(`
`1066`	`1066`	`*[_datetrunc_eq_expression(l, drange, target_type) for drange in ranges], copy=False`