Authenticate the release smoke test's health probe#597
Merged
Conversation
Every HTTP route now requires the session token, so the smoke test's plain curl to /api/health gets a 401: the readiness poll never sees a 200 and the build fails on every platform after the binary is already built. Read the token the server persists on boot and send it as a bearer header on both the readiness poll and the version check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every HTTP route now requires the session token, but the release smoke test still probes
/api/healthwith a plaincurl. The server answers 401, the readiness poll never sees a 200, and the build fails on every platform after the binary is already built. That blocks the five standalone-executable jobs and, through them, the prerelease attach and the compat/snap/flatpak/PyPI fan-out.Solution
Read the token the server persists to
server.jsonon boot and send it as a bearer header on both the readiness poll and the version check, matching what the CLI health probes already do.