Repository navigation
fix(skills): default cache hints and preserve legacy wire responses - #1
Merged
tobi-oye merged 1 commit intoSep 23, 2026
Merged
Conversation
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the cache-hint review on upstream draft #2818. This PR targets
feat/ext-skills-phase-1in this fork so the fix can be reviewed before updating the upstream draft.cacheHintto{ ttlMs: 0, cacheScope: 'private' }for bothskills/listandskills/get.Validation
pnpm build:all,pnpm typecheck:all, andpnpm lint:all(including snippet sync).git diff --checkpassed.The first sandboxed client-suite run timed out in localhost HTTP/SSE tests; rerunning with localhost access passed all 896 tests.
Implemented and tested with Codex assistance.