Fix moderator tracking for USERSTATE messages #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The USERSTATE message contains the channel that it's being sent for but this was not being used. Instead it used the `this.lastJoined` variable. However, this internal variable is only updated after the tracking for moderators is completed. This results in moderator status being assigned to the wrong channel and will result in `client.isMod` returning `false` when called in an `onJoin` handler (or thereafter).
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USERSTATE message contains the channel that it's
being sent for but this was not being used. Instead it used
the
this.lastJoinedvariable. However, this internal variableis only updated after the tracking for moderators is completed.
This results in moderator status being assigned to the wrong
channel and will result in
client.isModreturningfalsewhencalled in an
onJoinhandler (or thereafter).