utils: remove isString

AlcaDesign · AlcaDesign · commit 5ea712f89d23 · 2021-03-11T23:42:36.000-06:00
diff --git a/lib/client.js b/lib/client.js
@@ -115,7 +115,7 @@ client.prototype.handleMessage = function handleMessage(message) {
 		if(typeof value === 'boolean') { value = null; }
 		else if(value === "1") { value = true; }
 		else if(value === "0") { value = false; }
-		else if(_.isString(value)) { value = _.unescapeIRC(value); }
+		else if(typeof value === 'string') { value = _.unescapeIRC(value); }
 		tags[key] = value;
 	}
 
diff --git a/lib/parser.js b/lib/parser.js
@@ -32,7 +32,7 @@ function parseComplexTag(tags, tagKey, splA = ",", splB = "/", splC) {
 		return tags;
 	}
 
-	var tagIsString = _.isString(raw);
+	var tagIsString = typeof raw === 'string';
 	tags[tagKey + "-raw"] = tagIsString ? raw : null;
 
 	if(raw === true) {
diff --git a/lib/utils.js b/lib/utils.js
@@ -20,9 +20,6 @@ var self = module.exports = {
 	// Value is a regex..
 	isRegex: str => /[\|\\\^\$\*\+\?\:\#]/.test(str),
 
-	// Value is a string..
-	isString: str => typeof(str) === "string",
-
 	// Value is a valid url..
 	isURL: str => new RegExp("^(?:(?:https?|ftp)://)(?:\\S+(?::\\S*)?@)?(?:(?!(?:10|127)(?:\\.\\d{1,3}){3})(?!(?:169\\.254|192\\.168)(?:\\.\\d{1,3}){2})(?!172\\.(?:1[6-9]|2\\d|3[0-1])(?:\\.\\d{1,3}){2})(?:[1-9]\\d?|1\\d\\d|2[01]\\d|22[0-3])(?:\\.(?:1?\\d{1,2}|2[0-4]\\d|25[0-5])){2}(?:\\.(?:[1-9]\\d?|1\\d\\d|2[0-4]\\d|25[0-4]))|(?:(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)(?:\\.(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)*(?:\\.(?:[a-z\\u00a1-\\uffff]{2,}))\\.?)(?::\\d{2,5})?(?:[/?#]\\S*)?$","i").test(str),
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ client.prototype.handleMessage = function handleMessage(message) {`
`115`	`115`	`if(typeof value === 'boolean') { value = null; }`
`116`	`116`	`else if(value === "1") { value = true; }`
`117`	`117`	`else if(value === "0") { value = false; }`
`118`		`- else if(_.isString(value)) { value = _.unescapeIRC(value); }`
	`118`	`+ else if(typeof value === 'string') { value = _.unescapeIRC(value); }`
`119`	`119`	`tags[key] = value;`
`120`	`120`	`}`
`121`	`121`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ function parseComplexTag(tags, tagKey, splA = ",", splB = "/", splC) {`
`32`	`32`	`return tags;`
`33`	`33`	`}`
`34`	`34`
`35`		`- var tagIsString = _.isString(raw);`
	`35`	`+ var tagIsString = typeof raw === 'string';`
`36`	`36`	`tags[tagKey + "-raw"] = tagIsString ? raw : null;`
`37`	`37`
`38`	`38`	`if(raw === true) {`