Skip duplicate cowfiles bugfix #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass ENV var from host command line > docker build with build arg > dockerfile build arg > dockerfile env var from build arg > env var detected by png_convert Now you can run the build/docker task in debug mode with: `DEBUG=1 make build/docker`
currently this is only skipping duplicate cowfiles if debug is true, which previously was never thanks to some bugs when handling the args. now - always skip duplicate cowfiles - and if in debug mode, log a message
to mitigate the error ``` 2025/11/12 12:25:13 mkdir build/assets: permission denied ```
to mitigate the error ``` ./build/scripts/build_bin.sh: line 14: pokesay.1: Permission denied ```
and run in debug mode, currently getting a failure but it's not clear why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle annoying bug that was causing duplicate cowfiles to not be skipped as intended in the dockerfile build
The existing
cows.tar.gzdidn't have this issue, but this file is just an artefact to aid those who want to build the tool but can't run docker (e.g. in termux)Changes
build/dockertask.Now you can build in debug mode with: