-
Notifications
You must be signed in to change notification settings - Fork 3
Flip horizontal #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Flip horizontal #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
green for yay, red for nay
tidy implementation add comments improve unit tests
This reverts commit 88565c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Over time, I've found it awkward that the pokemon sprites always face to the left, which is usually the very edge of the terminal.
Additionally, in future I'd like to make it possible to have the speech bubble placed horizontally beside the pokemon, rather than always being vertically above
Changes
This introduces the ability to "flip" any pokemon with
-For--flipThis is a rough initial implementation that works 100% correctly 🎉, and I'll improve the algorithm over time
Each reversed line will end with an ANSI reset code, allowing a speech bubble (or anything) to be placed to the right without having to worry about the colours
Each line also ends with padding spaces resulting in a "square", so alignment is also not an issue
In future I'll also update the regular sprites to work like this too