skip duplicate cowfile images #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- collect list of all cowfile data before each is written - check all data against previous entries before writing - skip if data was already written this skips around 1500 files! which lowers the total from ~5000 to ~3500 this results in a small file size decrease, and a small speed increase (no more than 10%)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
I lowered the number of cowfiles from
~5000to~3500by removing duplicatesContext
When doing some unrelated debugging I noticed that there were pokemon entries that seemed to be straight-up duplicates, e.g. the variations of Lament here (between gen7 and gen8)
Upon inspecting the text, I found that this was indeed the case
Changes
this skips around 1500 files! which lowers the total from
~5000to~3500this results in a small file size decrease, and a small speed increase (no more than 10%)