Skip to content

Support printing IDs and selecting by ID #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmck-code merged 16 commits into from
Sep 18, 2025
Merged

Support printing IDs and selecting by ID #62

tmck-code merged 16 commits into from
Sep 18, 2025

Conversation

@tmck-code
Copy link
Owner

@tmck-code tmck-code commented Apr 4, 2024 •
edited
Loading

Context

When using pokesay, it's possible to select a Pokemon's name and category, and then the final choice is made by randomly selecting between those.

This change gives each pokemon avatar a distinct ID so that an exact pokemon avatar can be selected

Command Line args

operation screenshot
list IDs for a Pokémon (or all Pokémon with just -l Screenshot_20240405-095516
Get specific Pokémon via ID Screenshot_20240405-095711
display the ID in the info bar with -I Screenshot_20240405-095741

Notes

This change isn't perfect, but it's been sitting here for over a year so I figured that I should just merge it. Thoughts for the future:

  • The ID is made up of a sequential ID for the pokemon, and a n ID for the variant. The variant IDs are not sorted which makes them a little unintuitive to use. A better version might increment them for each pokemon from 001 onwards
    • example of current ID: "0904.0834"
  • This PR initially included a change to greatly increase the number of categories. While this is pretty cool, a large amount of categories only apply to a single pokemon, there's some tidy up/extra logic required before this could become a thing

tmck-code added 16 commits April 4, 2024 18:33
@tmck-code
Support printing IDs and selecting by ID
b9b36e2 
- print JSON of id -> name
- allow selection via id with -i
@tmck-code
print metadata IDs as sub-ids
17e5d8d
@tmck-code
implement selecting via ID pair
294af98 
e.g. -i 904.4217
@tmck-code
sort metadata when building
c6c0f27 
this saves complexity when reading/selecting
- sort the metadata entries by the name tokens before writing
- add an Idx field to the metadata struct
@tmck-code
list the indexes for all names, or a select name
5e586ef 
with either -l/--l=name
@tmck-code
print the ID alongside the names/categories
592b908
@tmck-code
select by ID function
196c141
@tmck-code
Add a CLI flag to toggle ID in info box
9e2ca93
@tmck-code
cleanup
cb4f26c
@tmck-code
add moar categories
16f642b 
there are additional categories for each pokemon that I haven't dealt
with until now.

each cowfile has a path like
- gen7x/regular/charizard.cow
- gen7x/regular/charizard-mega-y.cow
- gen7x/regular/charizard-mega-y.cow

Everything after the first - in the basename is now parsed out into an
extra category

This makes the -l mode more transparent, and allows selection of cool
stuff like shiny/mega etc.
@tmck-code
better indexes!
957875b 
TODO: clean and implement properly
@tmck-code
Merge branch 'master' into print-pokemon-by-id
1e20f30
@tmck-code
Revert "add moar categories"
ca7156e 
This reverts commit 16f642b.
@tmck-code
Merge branch 'master' into print-pokemon-by-id
ac09f1c
@tmck-code
update readme
0c096be
@tmck-code
remove verbose print debugging
26e8346
@tmck-code tmck-code merged commit d2c5d65 into master Sep 18, 2025
1 check passed
@tmck-code tmck-code deleted the print-pokemon-by-id branch September 18, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmck-code